Use actual nbsp character instead of HTML entity when avoiding wrapping rule names in rules list #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… names in rule list
|
LGTM - it makes the raw markdown visually cleaner, and there's no user confusion issue since the doc generator will be creating it. |
MichaelDeBoey
approved these changes
Oct 26, 2022
ddzz
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a bug fix but more like a tweak with no user-facing behavior change.
Avoids excessively-long name column in markdown due to repeated
HTML entity as seen here: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/7d804e3ce8ecb9d51b16d558eeae6dc12a81ec4c/readme.md?plain=1#L53Non-breaking space character copied from here: https://unicode-table.com/en/00A0/
Idea suggested here: jsx-eslint/eslint-plugin-react#3469 (comment)
This is a follow-up to the original issue for avoiding wrapping rule names: #110.
The only downside I see is that it this non-breaking space can be indistinguishable from a regular space to many readers and could cause confusion. The HTML entity is more clear.
What do you think? Add thumbs up or thumbs down emoji to this PR.
CC: @ljharb @sindresorhus @fisker