Skip to content

Drop support for Node 12 and Node 17 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmish merged 4 commits into from
May 23, 2023
Merged

Drop support for Node 12 and Node 17 #495

bmish merged 4 commits into from
May 23, 2023

Conversation

@ddzz
Copy link
Collaborator

@ddzz ddzz commented Jul 31, 2022 •
edited by bmish
Loading

@ddzz ddzz requested a review from bmish July 31, 2022 23:37
bmish
bmish reviewed Jul 31, 2022
View reviewed changes
@bmish bmish added the breaking label Jul 31, 2022
@bmish bmish mentioned this pull request Jul 31, 2022
Closed
@ddzz @bmish
Update package.json
dc7bb4f 
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@ddzz ddzz requested a review from bmish August 14, 2022 16:44
@ddzz
Copy link
Collaborator Author

ddzz commented Dec 3, 2022

@bmish can we merge this now to get the Dependabot PRs merged?

@bmish
Copy link
Owner

bmish commented Dec 3, 2022

I added my criteria for performing a major release in #346. Currently, I don't think we meet the criteria, since:

  • We haven't prepared any substantive breaking changes yet
  • There's not much ongoing active development
  • We don't have a specific need for any of the new dependency versions that I'm aware of

If any of those change, I would be happy to perform a major release.

@bmish bmish mentioned this pull request May 12, 2023
Merged
@ddzz
Copy link
Collaborator Author

ddzz commented May 22, 2023

@bmish Can this be merged?

bmish
bmish approved these changes May 23, 2023
View reviewed changes
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit 150181d into main May 23, 2023
@bmish bmish deleted the node-12-17 branch May 23, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmish bmish bmish approved these changes

Assignees

No one assigned

Labels

breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddzz @bmish