Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV Bulk Loading Improvements #150

Merged
merged 13 commits into from
Oct 5, 2018
Merged

KV Bulk Loading Improvements #150

merged 13 commits into from
Oct 5, 2018

Conversation

kellrott
Copy link
Member

This PR adds methods and options to:

  • Enable bulk loading of KeyValue based graphs
  • Build Rocks driver using local RockDB build, rather then rely on system install
  • File suffix recognition in bulk loader (".gz" decompress)

@kellrott kellrott requested a review from adamstruck September 30, 2018 10:56
adamstruck
adamstruck reviewed Oct 2, 2018
View reviewed changes
test/kvbench/util.go Outdated

var idRunes = []rune("abcdefghijklmnopqrstuvwxyz")

func randID() string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dup of https://github.com/bmeg/grip/blob/master/util/random.go#L16

@adamstruck adamstruck merged commit a73e197 into master Oct 5, 2018
@adamstruck adamstruck deleted the kv-dev-2 branch October 5, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstruck adamstruck adamstruck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellrott @adamstruck