Throw if performFn is valid but callback is not#13
Open
NealEhardt wants to merge 2 commits intobmeck:masterfrom
Open
Throw if performFn is valid but callback is not#13NealEhardt wants to merge 2 commits intobmeck:masterfrom
NealEhardt wants to merge 2 commits intobmeck:masterfrom
Conversation
test/no-functions.js
Outdated
Collaborator
There was a problem hiding this comment.
I believe you also want to make the same change you made to the actor.before statement above.
Author
There was a problem hiding this comment.
If you look at the file after changes, I deleted actor.after and modified actor.before. I think actor.after is redundant in this case.
Collaborator
There was a problem hiding this comment.
It's not redundant. It's an additional assertion that should never be hit: after hooks should not be executed. If they are it's a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error checking for the following scenario: