Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tracing for client methods #365

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Adds tracing for client methods #365

merged 3 commits into from
Nov 17, 2023

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

Adds the WithTraceProvider() client option to accept a trace provider,
with a trace provider, the client methods are traced with annotations from the client metadata.

Checklist

  • Tests added
  • Similar commits squashed

Description for changelog/release notes

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (4666b85) 44.99% compared to head (2f99df1) 44.29%.

Files Patch % Lines
client.go 7.95% 81 Missing ⚠️
bmc/bmc.go 15.78% 16 Missing ⚠️
option.go 0.00% 4 Missing ⚠️
bmc/firmware.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   44.99%   44.29%   -0.70%     
==========================================
  Files          60       61       +1     
  Lines        5025     5145     +120     
==========================================
+ Hits         2261     2279      +18     
- Misses       2508     2610     +102     
  Partials      256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelrebel joelrebel merged commit b0ef181 into main Nov 17, 2023
5 of 7 checks passed
@joelrebel joelrebel deleted the tracing branch November 17, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants