-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floppy upload and unmount #347
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 45.08% 44.50% -0.58%
==========================================
Files 54 56 +2
Lines 4228 4417 +189
==========================================
+ Hits 1906 1966 +60
- Misses 2110 2234 +124
- Partials 212 217 +5
☔ View full report in Codecov by Sentry. |
a5e00a3
to
1bbb62f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK. I find the usage of Upload
vs. Unmount
jarring and I'd prefer those be more consistent, but as is this is functional.
You're completely right - I was on fence about the current naming, updated now. |
1bfd322
to
7932b1c
Compare
force pushed to rebase on main |
What does this PR implement/change/remove?
Defines and implements the floppy upload and unmount feature for Supermicro X11, X12 BMCs.
This enables uploading a floppy image onto the BMC, which can then be used to boot off the image.
This differs from mounting remote images as virtual media, which can timeout over time.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)