Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floppy upload and unmount #347

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Floppy upload and unmount #347

merged 6 commits into from
Oct 31, 2023

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

Defines and implements the floppy upload and unmount feature for Supermicro X11, X12 BMCs.
This enables uploading a floppy image onto the BMC, which can then be used to boot off the image.

This differs from mounting remote images as virtual media, which can timeout over time.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

  • Supermicro

The HW model number, product name this change applies to (if applicable)

  • X11, X12

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (25d7063) 45.08% compared to head (7932b1c) 44.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   45.08%   44.50%   -0.58%     
==========================================
  Files          54       56       +2     
  Lines        4228     4417     +189     
==========================================
+ Hits         1906     1966      +60     
- Misses       2110     2234     +124     
- Partials      212      217       +5     
Files Coverage Δ
client.go 56.55% <0.00%> (-1.92%) ⬇️
providers/supermicro/supermicro.go 42.50% <15.38%> (-1.89%) ⬇️
internal/redfishwrapper/virtual_media.go 0.00% <0.00%> (ø)
bmc/floppy.go 76.31% <76.31%> (ø)
providers/supermicro/floppy.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelrebel joelrebel force-pushed the floppy-upload branch 2 times, most recently from a5e00a3 to 1bbb62f Compare October 20, 2023 05:36
@joelrebel joelrebel marked this pull request as ready for review October 20, 2023 05:37
DoctorVin
DoctorVin previously approved these changes Oct 30, 2023
Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. I find the usage of Upload vs. Unmount jarring and I'd prefer those be more consistent, but as is this is functional.

@joelrebel
Copy link
Member Author

joelrebel commented Oct 31, 2023

Seems OK. I find the usage of Upload vs. Unmount jarring and I'd prefer those be more consistent, but as is this is functional.

You're completely right - I was on fence about the current naming, updated now.

@joelrebel
Copy link
Member Author

joelrebel commented Oct 31, 2023

force pushed to rebase on main

@joelrebel joelrebel merged commit 81949eb into main Oct 31, 2023
5 of 7 checks passed
@joelrebel joelrebel deleted the floppy-upload branch October 31, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants