manager: optimize APM update check #1342
Open
+26
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangQi0408 <a123er3643@163.com>
pomelohan
approved these changes
Dec 25, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the APM (Android Patch Manager) module update checking by preventing redundant API calls to GitHub. The optimization introduces a flag to track whether an update check has been performed for each module, ensuring checks only occur once per session rather than on every recomposition.
Key changes:
- Added
updateCheckDonestate flag to track completion of update checks per module - Wrapped the
checkUpdatecall in a conditional that only executes whenupdateCheckDoneis false
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: YangQi0408 <a123er3643@163.com>
Contributor
Author
|
@pomelohan please review again, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for APM updates only when first entering the APM page or refreshing the APM page
before
QQ20251223-221534.mp4
"Attack" the GitHub server lol