Skip to content

Commit 4f15233

Browse files
Nagarjuna KristamMani-Sadhasivam
authored andcommitted
PCI: tegra194: Fix duplicate PLL disable in pex_ep_event_pex_rst_assert()
During PERST# assertion tegra_pcie_bpmp_set_pll_state() is currently called twice. pex_ep_event_pex_rst_assert() should do the opposite of pex_ep_event_pex_rst_deassert(), so it is obvious that the duplicate tegra_pcie_bpmp_set_pll_state() is a mistake, and that the duplicate tegra_pcie_bpmp_set_pll_state() call should instead be a call to tegra_pcie_bpmp_set_ctrl_state(). With this, the uninitialization sequence also matches that of tegra_pcie_unconfig_controller(). Fixes: a54e190 ("PCI: tegra194: Add Tegra234 PCIe support") Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> [cassel: improve commit log] Signed-off-by: Niklas Cassel <cassel@kernel.org> Link: https://patch.msgid.link/20250911093021.1454385-2-cassel@kernel.org [mani: added Fixes tag] Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
1 parent e1a8805 commit 4f15233

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/pci/controller/dwc/pcie-tegra194.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,9 +1722,9 @@ static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie)
17221722
ret);
17231723
}
17241724

1725-
ret = tegra_pcie_bpmp_set_pll_state(pcie, false);
1725+
ret = tegra_pcie_bpmp_set_ctrl_state(pcie, false);
17261726
if (ret)
1727-
dev_err(pcie->dev, "Failed to turn off UPHY: %d\n", ret);
1727+
dev_err(pcie->dev, "Failed to disable controller: %d\n", ret);
17281728

17291729
pcie->ep_state = EP_STATE_DISABLED;
17301730
dev_dbg(pcie->dev, "Uninitialization of endpoint is completed\n");

0 commit comments

Comments
 (0)