Skip to content

Commit e1a8805

Browse files
aloktiwabjorn-helgaas
authored andcommitted
PCI: tegra: Fix devm_kcalloc() argument order for port->phys allocation
Fix incorrect argument order in devm_kcalloc() when allocating port->phys. The original call used sizeof(phy) as the number of elements and port->lanes as the element size, which is reversed. While this happens to produce the correct total allocation size with current pointer size and lane counts, the argument order is wrong. Fixes: 6fe7c18 ("PCI: tegra: Support per-lane PHYs") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> [mani: added Fixes tag] Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Link: https://patch.msgid.link/20250819150436.3105973-1-alok.a.tiwari@oracle.com
1 parent 8f5ae30 commit e1a8805

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/pci-tegra.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1344,7 +1344,7 @@ static int tegra_pcie_port_get_phys(struct tegra_pcie_port *port)
13441344
unsigned int i;
13451345
int err;
13461346

1347-
port->phys = devm_kcalloc(dev, sizeof(phy), port->lanes, GFP_KERNEL);
1347+
port->phys = devm_kcalloc(dev, port->lanes, sizeof(phy), GFP_KERNEL);
13481348
if (!port->phys)
13491349
return -ENOMEM;
13501350

0 commit comments

Comments
 (0)