Skip to content

fix(quick-dev): specify project-root anchor for context list paths#2200

Merged
alexeyv merged 1 commit intomainfrom
fix/context-path-resolution
Apr 3, 2026
Merged

fix(quick-dev): specify project-root anchor for context list paths#2200
alexeyv merged 1 commit intomainfrom
fix/context-path-resolution

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Apr 3, 2026

What

Clarify that context: list entries in quick-dev spec frontmatter must use project-root-prefixed paths, matching BMAD existing path resolution convention.

Why

The original implementation (PR #2185) left path format ambiguous -- entries could be interpreted as repo-root, project-root-prefixed, or spec-relative, leading to failed or wrong file loads.

How

  • Updated spec-template comment to document project-root-prefixed paths
  • Updated step-03 to resolve context paths relative to project-root
  • Updated step-04 acceptance auditor to note paths are project-root-relative

Testing

  • npm run quality passes

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 34e5f1c7-6333-411c-93d1-74d3c919e83e

📥 Commits

Reviewing files that changed from the base of the PR and between e9a6bfa and 9a187c2.

📒 Files selected for processing (3)
  • src/bmm-skills/4-implementation/bmad-quick-dev/spec-template.md
  • src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md
  • src/bmm-skills/4-implementation/bmad-quick-dev/step-04-review.md

📝 Walkthrough

Walkthrough

The PR clarifies context path resolution conventions across three bmad-quick-dev workflow instruction files, specifying that frontmatter context paths are project-root-relative and must be explicitly resolved before use.

Changes

Cohort / File(s) Summary
Context path resolution clarifications
src/bmm-skills/4-implementation/bmad-quick-dev/spec-template.md, src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md, src/bmm-skills/4-implementation/bmad-quick-dev/step-04-review.md
Updated template documentation and workflow step instructions to explicitly clarify that context frontmatter paths must be resolved relative to {project-root} before loading or referencing referenced files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #2109: Directly modifies the same template and workflow files, renaming conventions that these clarifications apply to.
  • PR #2049: Enforces project-root-relative path conventions consistent with the context path resolution being clarified here.
  • PR #2185: Also modifies quick-dev spec and context handling, complementing these path resolution clarifications with awareness of planning artifacts and context file passing.

Suggested reviewers

  • bmadcode
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: specifying project-root anchoring for context list paths in quick-dev specs, which is the core fix addressed across all three modified files.
Description check ✅ Passed The description is directly related to the changeset, explaining the ambiguity in path resolution that was fixed and detailing how each file was updated to clarify project-root-relative paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/context-path-resolution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexeyv alexeyv force-pushed the fix/context-path-resolution branch from 9a187c2 to 183f77b Compare April 3, 2026 18:41
@alexeyv alexeyv merged commit d51e215 into main Apr 3, 2026
5 checks passed
@alexeyv alexeyv deleted the fix/context-path-resolution branch April 3, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant