Skip to content

feat: add SRE Lead persona (Morgan) for observability and reliability#2198

Closed
don-petry wants to merge 2 commits intobmad-code-org:mainfrom
don-petry:feature/sre-lead-persona
Closed

feat: add SRE Lead persona (Morgan) for observability and reliability#2198
don-petry wants to merge 2 commits intobmad-code-org:mainfrom
don-petry:feature/sre-lead-persona

Conversation

@don-petry
Copy link
Copy Markdown

@don-petry don-petry commented Apr 3, 2026

Summary

  • Adds SRE Lead persona ("Morgan") for observability, incident response, SLO/SLI definition, error budgets, and production resilience
  • Complements DevOps Lead (Riley) from feat: add DevOps Lead persona (Riley) #2190 — DevOps owns build/deploy, SRE owns run/observe/respond
  • Registered in module-help.csv (SL code, 3-solutioning phase) and docs/reference/agents.md
  • Follows exact v6 SKILL.md format matching all existing agents

Test plan

  • Install BMAD with new agent and verify Morgan activates correctly
  • Verify menu code SL invokes the SRE Lead from orchestrator
  • Confirm CA and IR capabilities invoke existing skills while maintaining Morgan's persona
  • Test fuzzy matching for "sre", "reliability", "Morgan"

Fixes #2197

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 3, 2026 11:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the BMM “solutioning” phase by adding an SRE Lead persona (“Morgan”) and registering new DevOps/SRE-related commands and workflows intended to cover reliability/operations planning (observability, incident response readiness, infrastructure strategy, and CI/CD pipeline design).

Changes:

  • Added new agent personas: SRE Lead (Morgan) and DevOps Lead (Riley).
  • Added two new guided workflows: bmad-create-infrastructure and bmad-create-pipeline (micro-file workflow architecture + templates/steps).
  • Updated help/catalog registration and architecture workflow copy to point users to the new infra/pipeline workflows; updated agents reference docs.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/bmm-skills/module-help.csv Registers new DevOps/SRE agent entries and the new infra/pipeline workflows in the help catalog.
src/bmm-skills/3-solutioning/bmad-create-pipeline/workflow.md Adds the pipeline workflow entrypoint and activation instructions.
src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-01-init.md Pipeline workflow initialization step (document discovery, CI/CD scan, template creation).
src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-02-pipeline-architecture.md Captures foundational CI/CD platform/branching/runner decisions.
src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-03-pipeline-stages.md Guides collaborative design of end-to-end pipeline stages.
src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-04-deployment-strategy.md Guides deployment strategy decisions (rollbacks, migrations, zero-downtime, etc.).
src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-05-validation.md Validates the pipeline plan and finalizes the pipeline artifact.
src/bmm-skills/3-solutioning/bmad-create-pipeline/SKILL.md Registers the pipeline workflow skill entrypoint.
src/bmm-skills/3-solutioning/bmad-create-pipeline/pipeline-template.md Provides the initial pipeline decision document template/frontmatter.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/workflow.md Adds the infrastructure workflow entrypoint and activation instructions.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-01-init.md Infrastructure workflow initialization (document discovery + infra indicators scan).
src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-02-iac-strategy.md Guides IaC tool/state/modules/policy/drift decisions.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-03-environment-strategy.md Guides environment topology, config/secrets, parity, cost mgmt decisions.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-04-container-strategy.md Guides containerization/runtime/orchestrator/registry/manifest decisions.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-05-validation.md Validates infrastructure decisions and finalizes the infrastructure artifact.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/SKILL.md Registers the infrastructure workflow skill entrypoint.
src/bmm-skills/3-solutioning/bmad-create-infrastructure/infrastructure-template.md Provides the initial infrastructure decision document template/frontmatter.
src/bmm-skills/3-solutioning/bmad-create-architecture/steps/step-04-decisions.md Adds a note pointing users to the dedicated DevOps workflows post-architecture.
src/bmm-skills/3-solutioning/bmad-agent-sre/SKILL.md Introduces Morgan (SRE Lead) persona + capability routing.
src/bmm-skills/3-solutioning/bmad-agent-devops/SKILL.md Introduces Riley (DevOps Lead) persona + capability routing.
docs/reference/agents.md Documents the new DevOps/SRE default agents and their triggers/workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🧹 Nitpick comments (1)
src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-05-validation.md (1)

240-269: Optional: Grammar consistency in compound adjectives.

Lines 245 and 255 use "Project-type specific" and "project-type specific" where the compound adjective "project-type-specific" (with hyphen before "specific") would follow standard English grammar for compound modifiers. This is a minor consistency improvement in the checklist sections.

📝 Optional grammar fix
-✅ Project-type specific gaps identified and addressed
+✅ Project-type-specific gaps identified and addressed
-❌ Missing project-type specific gap analysis
+❌ Missing project-type-specific gap analysis
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-05-validation.md`
around lines 240 - 269, Update the compound adjective instances "Project-type
specific" and "project-type specific" in the step-05-validation.md content so
they use standard hyphenation "project-type-specific" (and
"Project-type-specific" if sentence-initial/capitalized) for consistency; search
for the exact phrases "Project-type specific" and "project-type specific" in the
SUCCESS METRICS / FAILURE MODES checklist and replace them with the hyphenated
form while preserving surrounding punctuation and capitalization.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-02-iac-strategy.md`:
- Around line 107-111: Replace the shell-style fenced code blocks under the
"Verify Technology Versions" section with web search blocks: change the blocks
containing "{{selected_tool}} latest stable version" and "{{selected_tool}}
current LTS version" to use ```web fenced blocks so the queries become web
searches (i.e., wrap each query in a ```web ... ``` block rather than plain ```
code fences).

In
`@src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-04-container-strategy.md`:
- Around line 156-160: Update the two generic code fences under the "**Verify
Technology Versions**" section so web searches use the `web` identifier: replace
the plain triple-backtick blocks containing "{{selected_orchestrator}} latest
stable version" and "{{selected_orchestrator}} production best practices" with
code fences that start with ```web (i.e., convert each ``` to ```web) so both
queries are executed as web searches.
- Around line 127-130: Replace the plain shell-style code block under the
"Verify Technology Versions" section that currently shows `Search the web:
"{{selected_runtime}} latest stable version"` with a web-search block: change
the fenced block to use the `web` identifier and include only
`{{selected_runtime}} latest stable version` as the query (update the block in
step-04-container-strategy.md inside the "Verify Technology Versions" section).

In `@src/bmm-skills/3-solutioning/bmad-create-infrastructure/workflow.md`:
- Line 21: The line containing "Load config from
`{project-root}/_bmad/bmm/config.yaml` and resolve::" has a punctuation
typo—replace the double-colon token "resolve::" with a single colon "resolve:"
so the activation instruction reads "...and resolve:"; update the exact string
in the workflow.md content to maintain consistent instruction formatting.

In
`@src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-02-pipeline-architecture.md`:
- Around line 118-122: In the "**Verify Technology Versions:**" section replace
the backticked shell-style search blocks that contain "Search the web: ..." with
`web`-identified code blocks; specifically update the two blocks under that
heading so they use ```web fences and include only the query text (e.g.,
"{{platform}} latest version features" and "{{platform}} pricing current")
instead of the "Search the web:" prefix so the queries are run as web searches.

In
`@src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-03-pipeline-stages.md`:
- Around line 87-91: In the "Verify Technology Versions" section replace the
current shell-style search snippets that read 'Search the web: "{{build_tool}}
latest stable version"' and 'Search the web: "{{build_tool}} caching best
practices"' with web-typed code blocks: use the heading "Verify Technology
Versions" and convert each search into its own ```web``` fenced block containing
the plain query text ({{build_tool}} latest stable version and {{build_tool}}
caching best practices) so the queries use the web identifier instead of shell.

In `@src/bmm-skills/3-solutioning/bmad-create-pipeline/workflow.md`:
- Around line 21-27: The activation contract in workflow.md has a typo
"resolve::" and is missing the {output_folder} variable referenced by
step-01-init.md; fix by renaming "resolve::" to "resolve:" (single colon) and
add `{output_folder}` to the resolved variables list alongside `{user_name}`,
`{communication_language}`, `{document_output_language}`,
`{planning_artifacts}`, and `{project_knowledge}` so the root workflow's
activation contract matches step-01-init.md expectations.

---

Nitpick comments:
In
`@src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-05-validation.md`:
- Around line 240-269: Update the compound adjective instances "Project-type
specific" and "project-type specific" in the step-05-validation.md content so
they use standard hyphenation "project-type-specific" (and
"Project-type-specific" if sentence-initial/capitalized) for consistency; search
for the exact phrases "Project-type specific" and "project-type specific" in the
SUCCESS METRICS / FAILURE MODES checklist and replace them with the hyphenated
form while preserving surrounding punctuation and capitalization.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 910fef02-2365-4d82-9bb6-8137c1fd9ae6

📥 Commits

Reviewing files that changed from the base of the PR and between 0edcd05 and 69866f9.

⛔ Files ignored due to path filters (1)
  • src/bmm-skills/module-help.csv is excluded by !**/*.csv
📒 Files selected for processing (20)
  • docs/reference/agents.md
  • src/bmm-skills/3-solutioning/bmad-agent-devops/SKILL.md
  • src/bmm-skills/3-solutioning/bmad-agent-sre/SKILL.md
  • src/bmm-skills/3-solutioning/bmad-create-architecture/steps/step-04-decisions.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/SKILL.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/infrastructure-template.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-01-init.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-02-iac-strategy.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-03-environment-strategy.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-04-container-strategy.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/steps/step-05-validation.md
  • src/bmm-skills/3-solutioning/bmad-create-infrastructure/workflow.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/SKILL.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/pipeline-template.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-01-init.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-02-pipeline-architecture.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-03-pipeline-stages.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-04-deployment-strategy.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/steps/step-05-validation.md
  • src/bmm-skills/3-solutioning/bmad-create-pipeline/workflow.md

@don-petry don-petry force-pushed the feature/sre-lead-persona branch from 69866f9 to 571c363 Compare April 3, 2026 11:54
@don-petry don-petry force-pushed the feature/sre-lead-persona branch from 571c363 to d6d49d1 Compare April 3, 2026 12:03
DJ and others added 2 commits April 3, 2026 11:18
Introduces an SRE Lead persona complementing the DevOps Lead (Riley).
Morgan owns observability, incident response, SLO/SLI definition,
error budgets, and production resilience. Grounded in Google SRE
principles and DORA research.

Refs: bmad-code-org#2197

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Required by the installer's manifest generator to populate
agent-manifest.csv and enable agent discovery/enrichment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@don-petry don-petry force-pushed the feature/sre-lead-persona branch from d6d49d1 to 9e7432a Compare April 3, 2026 18:18
@alexeyv
Copy link
Copy Markdown
Collaborator

alexeyv commented Apr 3, 2026

closing for the same reason as PR 2190

@alexeyv alexeyv closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: SRE Lead Persona for Observability, Incident Response, and Reliability Engineering

3 participants