fix: remove ancestor_conflict_check from all platforms#2158
Conversation
The ancestor directory walk was based on the false premise that IDEs like Claude Code inherit skills from parent directories — they do not. The check blocked legitimate installations when unrelated BMAD skills existed anywhere up the directory tree.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRemoves Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: This PR removes platform-level Changes:
Rationale/Notes: Based on updated understanding that these IDEs don’t inherit skills from parent directories, nested-workspace installs should no longer fail due to ancestor scans. 🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| console.log(''); | ||
| // Test 10: Removed — ancestor conflict check no longer applies (no IDE inherits skills from parent dirs) |
There was a problem hiding this comment.
test/test-installation-components.js:440 — With the ancestor-conflict suites removed, there’s no longer a test that asserts the new intended behavior (setup succeeds even when an ancestor dir contains BMAD skills), which could let regressions slip in if defaults/config change later. Consider adding at least one positive test case for this scenario for one of the affected IDEs.
Severity: medium
Other Locations
test/test-installation-components.js:492test/test-installation-components.js:609
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| @@ -33,7 +33,6 @@ platforms: | |||
| legacy_targets: | |||
| - .claude/commands | |||
| target_dir: .claude/skills | |||
There was a problem hiding this comment.
tools/installer/ide/platform-codes.yaml:35 — After removing ancestor_conflict_check from platform configs, there are still repo docs that state it’s required (e.g. tools/docs/native-skills-migration-checklist.md mentions it for Claude/Codex/OpenCode), which is now likely misleading. Consider aligning those docs/comments with the new behavior to avoid future confusion.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
ancestor_conflict_checkconfig from claude-code, codex, opencode, and junie in platform-codes.yamlTest plan
bmad initno longer errors when ancestor directories contain unrelated BMAD skills