feat(quick-dev): one-shot route generates spec trace file#2121
Conversation
One-shot changes now leave a lightweight spec file with frontmatter, intent summary, and suggested review order — eliminating numbering gaps when quick-dev is used as the primary dev loop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…cture Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🤖 Augment PR SummarySummary: Updates the Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
src/bmm-skills/4-implementation/bmad-quick-dev/step-01-clarify-and-route.md
Outdated
Show resolved
Hide resolved
📝 WalkthroughWalkthroughUpdated the one-shot workflow path to derive slug-based spec file names during routing and introduced a "Generate Spec Trace" phase that creates the spec file from a template. Modified the presentation phase to open the generated spec file with VS Code instead of all changed files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/bmm-skills/4-implementation/bmad-quick-dev/step-01-clarify-and-route.md (1)
56-57: Consider extracting the duplicated slug derivation logic.The slug derivation and
spec_fileassignment logic is identical between the one-shot route (lines 56-57) and the plan-code-review route (line 61). This duplication creates a maintenance burden if the logic needs updating.Consider extracting this into a shared instruction block referenced by both routes, or document that changes to one must be mirrored to the other.
Also applies to: 61-61
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/bmm-skills/4-implementation/bmad-quick-dev/step-01-clarify-and-route.md` around lines 56 - 57, The duplicated slug derivation and spec_file assignment used in the one-shot route and the plan-code-review route should be extracted into a single reusable instruction block (e.g., derive_spec_slug or spec_slug_derivation) and invoked by both routes; update the two places to call this shared block and remove the duplicated steps so changes to kebab-case slug rules, tracking-id prefixing, and existing-file suffixing (`-2`, `-3`, etc.) are made in one spot, or alternatively add a clear comment referencing the other route to ensure both are kept in sync.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/bmm-skills/4-implementation/bmad-quick-dev/step-01-clarify-and-route.md`:
- Around line 56-57: The duplicated slug derivation and spec_file assignment
used in the one-shot route and the plan-code-review route should be extracted
into a single reusable instruction block (e.g., derive_spec_slug or
spec_slug_derivation) and invoked by both routes; update the two places to call
this shared block and remove the duplicated steps so changes to kebab-case slug
rules, tracking-id prefixing, and existing-file suffixing (`-2`, `-3`, etc.) are
made in one spot, or alternatively add a clear comment referencing the other
route to ensure both are kept in sync.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9497eba0-cad7-4352-8952-fa36e29b2905
📒 Files selected for processing (2)
src/bmm-skills/4-implementation/bmad-quick-dev/step-01-clarify-and-route.mdsrc/bmm-skills/4-implementation/bmad-quick-dev/step-oneshot.md
Triage Summary3 findings -- FIX: 2, DISMISS: 1, DEFER: 0
Commit: 278bb3f0 -- refactor(quick-dev): deduplicate slug derivation and clarify title variable |
…riable Extract shared slug derivation logic above the route fork in step-01 so both one-shot and plan-code-review routes use a single instruction block. Add explicit title variable assignment in step-oneshot before it is referenced in the Generate Spec Trace section.
Summary
spec-{slug}.md) with frontmatter, intent summary, and suggested review order — eliminating numbering gaps when quick-dev is used as the primary dev loopspec_filefor both routes (not just plan-code-review)Test plan
spec-{slug}.mdtrace file appears in{implementation_artifacts}status: doneandroute: one-shot:linepathsnpm run validate:skillspasses (confirmed locally)🤖 Generated with Claude Code