Skip to content

chore(agents): cleanup skill manifests and remove shared manifest#2035

Merged
bmadcode merged 1 commit intomainfrom
chore/cleanup-skill-manifests
Mar 17, 2026
Merged

chore(agents): cleanup skill manifests and remove shared manifest#2035
bmadcode merged 1 commit intomainfrom
chore/cleanup-skill-manifests

Conversation

@bmadcode
Copy link
Copy Markdown
Collaborator

Summary

  • Updated per-agent bmad-skill-manifest.yaml files (9 agents)
  • Removed the now-redundant shared src/bmm/agents/bmad-skill-manifest.yaml after capabilities were inlined into SKILL.md

Test plan

  • All schema validation tests pass (52/52)
  • All installation component tests pass (232/232)
  • Linting, markdown linting, and formatting checks pass

Update per-agent bmad-skill-manifest.yaml files and remove the
now-redundant shared bmad-skill-manifest.yaml after capabilities
were inlined into SKILL.md.
@bmadcode bmadcode merged commit a1418df into main Mar 17, 2026
7 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1a164ceb-badb-4a99-851e-33aada085d76

📥 Commits

Reviewing files that changed from the base of the PR and between e5062a8 and 12ee3d5.

📒 Files selected for processing (10)
  • src/bmm/agents/bmad-agent-analyst/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-architect/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-dev/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-pm/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-qa/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-quick-flow-solo-dev/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-sm/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-tech-writer/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-agent-ux-designer/bmad-skill-manifest.yaml
  • src/bmm/agents/bmad-skill-manifest.yaml

📝 Walkthrough

Walkthrough

This change reclassifies nine agent manifests from type "agent" to type "skill" in their individual manifest files, and removes their duplicate definitions from the central agent manifest file.

Changes

Cohort / File(s) Summary
Agent Manifest Type Updates
src/bmm/agents/bmad-agent-analyst/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-architect/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-dev/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-pm/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-qa/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-quick-flow-solo-dev/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-sm/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-tech-writer/bmad-skill-manifest.yaml, src/bmm/agents/bmad-agent-ux-designer/bmad-skill-manifest.yaml
Changed manifest type field from "agent" to "skill" in all nine individual agent manifests.
Central Manifest Cleanup
src/bmm/agents/bmad-skill-manifest.yaml
Removed eight agent definitions (analyst, architect, dev, pm, qa, quick-flow-solo-dev, sm, ux-designer) that are now handled by individual skill manifests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • BMAD-METHOD#1941: Both PRs convert manifest resources from "agent" to "skill" type classification across multiple manifest files.
  • BMAD-METHOD#1948: Both PRs modify quick-flow/quick-dev agent-to-skill conversions and update related skill manifest entries.
  • BMAD-METHOD#1951: Both PRs perform manifest-type conversions to "skill" including QA and other agent skill references.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cleanup-skill-manifests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 17, 2026

🤖 Augment PR Summary

Summary: This PR standardizes BMM “agent” skill manifests and removes a legacy shared manifest.

Changes:

  • Updates nine per-agent bmad-skill-manifest.yaml files to declare type: skill
  • Deletes the shared src/bmm/agents/bmad-skill-manifest.yaml multi-entry mapping file

Technical Notes: This aligns agent directories with the broader skill-manifest format and relies on per-skill metadata (now in SKILL.md) rather than a centralized manifest.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@@ -1,4 +1,4 @@
type: agent
type: skill
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collectAgents()’s “new-format agent directory” handling in tools/cli/installers/lib/core/manifest-generator.js only emits _config/agent-manifest.csv entries for directories whose manifest is type: agent, so switching this to type: skill likely drops this persona from the agent manifest. Can you confirm that’s intended (since agent-manifest.csv is referenced by party-mode and used to enrich the help catalog)?

Severity: medium

Other Locations
  • src/bmm/agents/bmad-agent-architect/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-dev/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-pm/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-qa/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-quick-flow-solo-dev/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-sm/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-tech-writer/bmad-skill-manifest.yaml:1
  • src/bmm/agents/bmad-agent-ux-designer/bmad-skill-manifest.yaml:1

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant