Convert retrospective workflow to native skill packaging#1943
Conversation
🤖 Augment PR SummarySummary: Converts the phase-4 retrospective workflow into a native skill package. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
src/bmm/agents/sm.agent.yaml
Outdated
|
|
||
| - trigger: ER or fuzzy match on epic-retrospective | ||
| exec: "{project-root}/_bmad/bmm/workflows/4-implementation/retrospective/workflow.md" | ||
| exec: "{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md" |
There was a problem hiding this comment.
Since bmad-retrospective is now packaged as a skill (with SKILL.md as the permanent entrypoint), consider pointing this menu exec to {project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/SKILL.md instead of workflow.md so it aligns with the generated skill manifest path.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
📝 WalkthroughWalkthroughThis PR restructures the retrospective workflow by renaming it to "bmad-retrospective" and converting it to a skill-based workflow. Changes include updating the Scrum Master agent trigger path, introducing new skill documentation and manifest files, and simplifying the legacy retrospective manifest. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/bmm/agents/sm.agent.yaml (1)
30-33: Path correctly updated, but inconsistent with module-help.csv reference style.The path update from
retrospectivetobmad-retrospectiveis correct. However, there's an inconsistency:module-help.csv(context snippet) references this asskill:bmad-retrospective, while this agent trigger uses a direct path{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md.If the intent is to use skill-based invocation consistently, consider using
skill:bmad-retrospectivehere as well. If direct paths are intentional for agent triggers, this is fine but the pattern should be documented.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/bmm/agents/sm.agent.yaml` around lines 30 - 33, The exec path in sm.agent.yaml currently uses a direct file path for the ER trigger; update it to use the same skill-style reference used in module-help.csv (replace exec "{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md" with exec "skill:bmad-retrospective") so the trigger, exec, and module-help.csv consistently reference the skill name; if you intentionally want direct paths instead, add a comment or document the exception and ensure module-help.csv is adjusted to match.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/bmm/agents/sm.agent.yaml`:
- Around line 30-33: The exec path in sm.agent.yaml currently uses a direct file
path for the ER trigger; update it to use the same skill-style reference used in
module-help.csv (replace exec
"{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md"
with exec "skill:bmad-retrospective") so the trigger, exec, and module-help.csv
consistently reference the skill name; if you intentionally want direct paths
instead, add a comment or document the exception and ensure module-help.csv is
adjusted to match.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 26a253eb-29af-41a8-81d0-a3f8d225f80a
⛔ Files ignored due to path filters (1)
src/bmm/module-help.csvis excluded by!**/*.csv
📒 Files selected for processing (5)
src/bmm/agents/sm.agent.yamlsrc/bmm/workflows/4-implementation/bmad-retrospective/SKILL.mdsrc/bmm/workflows/4-implementation/bmad-retrospective/bmad-skill-manifest.yamlsrc/bmm/workflows/4-implementation/bmad-retrospective/workflow.mdsrc/bmm/workflows/4-implementation/retrospective/bmad-skill-manifest.yaml
💤 Files with no reviewable changes (1)
- src/bmm/workflows/4-implementation/retrospective/bmad-skill-manifest.yaml
3d884d4 to
6044d82
Compare
Summary
src/bmm/workflows/4-implementation/retrospectiveinto native skill directorysrc/bmm/workflows/4-implementation/bmad-retrospectivetype: skilland addSKILL.mdmodule-help.csvandsm.agent.yamlValidation
node tools/cli/bmad-cli.js install --directory /Users/alex/src/bmad --modules bmm --tools claude-code --yes/Users/alex/src/bmad/.claude/skills/bmad-retrospective/_bmad/_config/skill-manifest.csv; absent from_bmad/_config/workflow-manifest.csvworkflow.mdnpm test