Skip to content

Convert retrospective workflow to native skill packaging#1943

Merged
alexeyv merged 3 commits intomainfrom
convert-retrospective-skill
Mar 14, 2026
Merged

Convert retrospective workflow to native skill packaging#1943
alexeyv merged 3 commits intomainfrom
convert-retrospective-skill

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Mar 12, 2026

Summary

  • convert src/bmm/workflows/4-implementation/retrospective into native skill directory src/bmm/workflows/4-implementation/bmad-retrospective
  • set packaging to type: skill and add SKILL.md
  • preserve workflow behavior with only required name/path adjustments
  • update dependent references in module-help.csv and sm.agent.yaml

Validation

  • node tools/cli/bmad-cli.js install --directory /Users/alex/src/bmad --modules bmm --tools claude-code --yes
  • verified installed output at /Users/alex/src/bmad/.claude/skills/bmad-retrospective/
  • verified manifest placement: present in _bmad/_config/skill-manifest.csv; absent from _bmad/_config/workflow-manifest.csv
  • functional equivalence (mechanical protocol): normalized old-vs-new parity PASS for workflow.md
  • npm test

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 12, 2026

🤖 Augment PR Summary

Summary: Converts the phase-4 retrospective workflow into a native skill package.

Changes:

  • Renames/moves the workflow into bmad-retrospective and updates its internal name/installed_path
  • Adds SKILL.md + bmad-skill-manifest.yaml (type: skill) so it installs via the skill manifest
  • Updates SM agent trigger (and other references) to the new path

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.


- trigger: ER or fuzzy match on epic-retrospective
exec: "{project-root}/_bmad/bmm/workflows/4-implementation/retrospective/workflow.md"
exec: "{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since bmad-retrospective is now packaged as a skill (with SKILL.md as the permanent entrypoint), consider pointing this menu exec to {project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/SKILL.md instead of workflow.md so it aligns with the generated skill manifest path.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 12, 2026

📝 Walkthrough

Walkthrough

This PR restructures the retrospective workflow by renaming it to "bmad-retrospective" and converting it to a skill-based workflow. Changes include updating the Scrum Master agent trigger path, introducing new skill documentation and manifest files, and simplifying the legacy retrospective manifest.

Changes

Cohort / File(s) Summary
Agent Configuration
src/bmm/agents/sm.agent.yaml
Updated Epic Retrospective trigger path from .../retrospective/workflow.md to .../bmad-retrospective/workflow.md in Scrum Master agent manifest.
Retrospective Workflow Migration
src/bmm/workflows/4-implementation/bmad-retrospective/SKILL.md, src/bmm/workflows/4-implementation/bmad-retrospective/bmad-skill-manifest.yaml, src/bmm/workflows/4-implementation/bmad-retrospective/workflow.md
Added new skill-based retrospective workflow structure with SKILL.md documentation, skill manifest declaration, and renamed workflow configuration from "retrospective" to "bmad-retrospective" with simplified path resolution to current directory.
Legacy Workflow Cleanup
src/bmm/workflows/4-implementation/retrospective/bmad-skill-manifest.yaml
Removed workflow metadata (canonicalId, type, description) from old retrospective manifest file.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • bmadcode
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Convert retrospective workflow to native skill packaging' directly and clearly describes the main change in the changeset—converting the retrospective workflow from traditional workflow packaging to native skill packaging.
Description check ✅ Passed The description is directly related to the changeset, providing a detailed summary of the conversion work, validation steps, and expected behavior preservation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch convert-retrospective-skill
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/bmm/agents/sm.agent.yaml (1)

30-33: Path correctly updated, but inconsistent with module-help.csv reference style.

The path update from retrospective to bmad-retrospective is correct. However, there's an inconsistency: module-help.csv (context snippet) references this as skill:bmad-retrospective, while this agent trigger uses a direct path {project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md.

If the intent is to use skill-based invocation consistently, consider using skill:bmad-retrospective here as well. If direct paths are intentional for agent triggers, this is fine but the pattern should be documented.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/bmm/agents/sm.agent.yaml` around lines 30 - 33, The exec path in
sm.agent.yaml currently uses a direct file path for the ER trigger; update it to
use the same skill-style reference used in module-help.csv (replace exec
"{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md"
with exec "skill:bmad-retrospective") so the trigger, exec, and module-help.csv
consistently reference the skill name; if you intentionally want direct paths
instead, add a comment or document the exception and ensure module-help.csv is
adjusted to match.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/bmm/agents/sm.agent.yaml`:
- Around line 30-33: The exec path in sm.agent.yaml currently uses a direct file
path for the ER trigger; update it to use the same skill-style reference used in
module-help.csv (replace exec
"{project-root}/_bmad/bmm/workflows/4-implementation/bmad-retrospective/workflow.md"
with exec "skill:bmad-retrospective") so the trigger, exec, and module-help.csv
consistently reference the skill name; if you intentionally want direct paths
instead, add a comment or document the exception and ensure module-help.csv is
adjusted to match.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 26a253eb-29af-41a8-81d0-a3f8d225f80a

📥 Commits

Reviewing files that changed from the base of the PR and between 75ec4aa and 3d884d4.

⛔ Files ignored due to path filters (1)
  • src/bmm/module-help.csv is excluded by !**/*.csv
📒 Files selected for processing (5)
  • src/bmm/agents/sm.agent.yaml
  • src/bmm/workflows/4-implementation/bmad-retrospective/SKILL.md
  • src/bmm/workflows/4-implementation/bmad-retrospective/bmad-skill-manifest.yaml
  • src/bmm/workflows/4-implementation/bmad-retrospective/workflow.md
  • src/bmm/workflows/4-implementation/retrospective/bmad-skill-manifest.yaml
💤 Files with no reviewable changes (1)
  • src/bmm/workflows/4-implementation/retrospective/bmad-skill-manifest.yaml

@alexeyv alexeyv force-pushed the convert-retrospective-skill branch from 3d884d4 to 6044d82 Compare March 14, 2026 11:39
@alexeyv alexeyv merged commit 8dbc9b3 into main Mar 14, 2026
5 checks passed
@alexeyv alexeyv deleted the convert-retrospective-skill branch March 15, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant