fix(installer): separate skill and agent counts in summary#1932
fix(installer): separate skill and agent counts in summary#1932alexeyv merged 1 commit intobmad-code-org:mainfrom
Conversation
Subtract agents from total skill directories so the summary shows non-agent skills and agents as distinct counts (e.g. 34 skills, 10 agents) instead of double-counting agents in the skill total.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes refactor how installer summary skill counts are calculated. Instead of using a separate totalSkills value, the skill count is now derived by subtracting agents from the directory-based total (totalDirs). Tests are updated to reflect that skills are no longer reported in the detail summary alongside agent counts. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: Updates the installer summary/detail output to avoid double-counting agent skill directories in the overall “skills” total. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| const totalSkills = r.skillDirectories || (r.workflows || 0) + (r.tasks || 0) + (r.tools || 0) + (r.skills || 0); | ||
| if (totalSkills > 0) parts.push(`${totalSkills} skills`); | ||
| const totalDirs = r.skillDirectories || (r.workflows || 0) + (r.tasks || 0) + (r.tools || 0) + (r.skills || 0); | ||
| const skillCount = totalDirs - (r.agents || 0); |
There was a problem hiding this comment.
skillCount = totalDirs - (r.agents || 0) assumes agents maps 1:1 to directories included in skillDirectories; if agents is a write-count or if any names collide, this can undercount (or go negative and silently drop the skills portion). Consider guarding against that mismatch so the summary can’t drift from what was actually written.
Severity: low
Other Locations
tools/cli/installers/lib/ide/_config-driven.js:717
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
…-org#1932) Subtract agents from total skill directories so the summary shows non-agent skills and agents as distinct counts (e.g. 34 skills, 10 agents) instead of double-counting agents in the skill total.
1 participant
Summary
34 skills, 10 agentsinstead of44 skills, 10 agents)Verification
node test/test-installation-components.js— all 223 tests pass--tools claude-codeshows34 skills, 10 agents--tools noneshowsNo IDE selected