Skip to content

fix: address review findings from party-mode skill conversion#1919

Merged
alexeyv merged 1 commit intobmad-code-org:mainfrom
alexeyv:fix/party-mode-triage
Mar 12, 2026
Merged

fix: address review findings from party-mode skill conversion#1919
alexeyv merged 1 commit intobmad-code-org:mainfrom
alexeyv:fix/party-mode-triage

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Mar 12, 2026

Summary

  • Fix bare directory reference missing /workflow.md in step-02-generate.md (flagged by both Augment and CodeRabbit)
  • Remove stale workflowType: 'party-mode' from workflow.md and step-03-graceful-exit.md
  • Remove unused decorative party_mode_exec and advanced_elicitation aliases from quick-dev-new-preview workflow

Test plan

  • npm test passes
  • Grep confirms no bare bmad-party-mode directory references remain (all end with /workflow.md)
  • Grep confirms no workflowType: 'party-mode' remains in source

🤖 Generated with Claude Code

- Fix bare directory ref missing /workflow.md in step-02-generate.md
- Remove stale workflowType: 'party-mode' from workflow.md and step-03
- Remove unused decorative aliases from quick-dev-new-preview workflow

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexeyv alexeyv merged commit 861716f into bmad-code-org:main Mar 12, 2026
7 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b368216-564c-4a6f-b221-f656a56c3310

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba809c and a72fea3.

📒 Files selected for processing (4)
  • src/bmm/workflows/bmad-quick-flow/bmad-quick-dev-new-preview/workflow.md
  • src/bmm/workflows/generate-project-context/steps/step-02-generate.md
  • src/core/workflows/bmad-party-mode/steps/step-03-graceful-exit.md
  • src/core/workflows/bmad-party-mode/workflow.md

📝 Walkthrough

Walkthrough

The PR removes workflow metadata entries (workflowType fields and related workflow references) and updates a workflow path reference to explicitly point to a .md file instead of a directory.

Changes

Cohort / File(s) Summary
Quick-flow Frontmatter Cleanup
src/bmm/workflows/bmad-quick-flow/bmad-quick-dev-new-preview/workflow.md
Removed "Related workflows" block from frontmatter, eliminating references to advanced_elicitation and party_mode_exec.
Party-mode Workflow Configuration
src/core/workflows/bmad-party-mode/workflow.md, src/core/workflows/bmad-party-mode/steps/step-03-graceful-exit.md
Removed workflowType field from frontmatter YAML and graceful-exit completion step data.
Workflow Path Reference Update
src/bmm/workflows/generate-project-context/steps/step-02-generate.md
Updated path reference to explicitly point to bmad-party-mode/workflow.md instead of directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • bmadcode
  • pbean
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 12, 2026

🤖 Augment PR Summary

Summary: Cleans up workflow references and frontmatter after party-mode skill conversion review feedback.

Changes: Updates the party-mode invocation in generate-project-context to point explicitly at /workflow.md, removes stale workflowType: 'party-mode' frontmatter snippets, and drops unused related-workflow aliases from the quick-dev-new-preview workflow.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@alexeyv alexeyv deleted the fix/party-mode-triage branch March 12, 2026 06:56
alexeyv added a commit to alexeyv/BMAD-METHOD that referenced this pull request Mar 13, 2026
…d-code-org#1919)

- Fix bare directory ref missing /workflow.md in step-02-generate.md
- Remove stale workflowType: 'party-mode' from workflow.md and step-03
- Remove unused decorative aliases from quick-dev-new-preview workflow

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant