Skip to content

fix(bmm): normalize story status references to lowercase kebab-case#1108

Merged
muratkeremozcan merged 2 commits intobmad-code-org:mainfrom
alexeyv:fix/normalize-status-kebab-case
Dec 12, 2025
Merged

fix(bmm): normalize story status references to lowercase kebab-case#1108
muratkeremozcan merged 2 commits intobmad-code-org:mainfrom
alexeyv:fix/normalize-status-kebab-case

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Dec 12, 2025

Summary

  • Normalizes status references to use canonical lowercase kebab-case format (review instead of Ready for Review)
  • Updates dev-story workflow instructions and checklist
  • Updates daily-standup task status examples

Changes

File Change
dev-story/instructions.xml Status field → "review", output messages reference actual status
dev-story/checklist.md Status instruction → "review"
daily-standup.xml Status examples → "in-progress, review"

Context

Story lifecycle: backlog → ready-for-dev → in-progress → review → done

Fixes #1105

🤖 Generated with Claude Code

Updated status references to use canonical lowercase kebab-case format:

- dev-story/instructions.xml: Status field set to "review" (was "Ready for Review")
- dev-story/instructions.xml: Output messages reference actual "review" status
- dev-story/checklist.md: Status field instruction uses "review"
- daily-standup.xml: Status examples use "in-progress, review"

Story lifecycle: backlog → ready-for-dev → in-progress → review → done

Fixes bmad-code-org#1105

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@alexeyv alexeyv self-assigned this Dec 12, 2025
@alexeyv
Copy link
Copy Markdown
Collaborator Author

alexeyv commented Dec 12, 2025

@CodeRabbit review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 12, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 12, 2025

Walkthrough

The changes normalize story status labels across workflow files from mixed-case formats (e.g., "Ready for Review") to lowercase kebab-case (e.g., "review"), aligning with canonical status definitions used elsewhere in the system.

Changes

Cohort / File(s) Summary
Status Label Normalization
src/modules/bmm/tasks/daily-standup.xml, src/modules/bmm/workflows/4-implementation/dev-story/checklist.md, src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml
Updated story status references from capitalized phrases ("Ready for Review") to lowercase kebab-case ("review") across task definitions, workflow instructions, and checklists to match canonical status token format.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Consistent, repetitive text replacements with clear intent
  • No logic changes or control flow modifications
  • Changes are limited to status label normalization across a small set of files
  • Easy to verify against the canonical status definitions provided in the linked issue

Suggested reviewers

  • pbean
  • muratkeremozcan

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: normalizing story status references from Title Case to lowercase kebab-case format.
Description check ✅ Passed The description clearly explains the normalization changes and references the three modified files with concrete examples of the status value changes.
Linked Issues check ✅ Passed The PR directly addresses issue #1105 by updating all required status references from 'Ready for Review' to 'review' in instructions.xml, checklist.md, and daily-standup.xml files.
Out of Scope Changes check ✅ Passed All changes are directly related to normalizing status references in story workflow files; no unrelated modifications are present outside the stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed0defb and 7a9f1d4.

📒 Files selected for processing (3)
  • src/modules/bmm/tasks/daily-standup.xml (1 hunks)
  • src/modules/bmm/workflows/4-implementation/dev-story/checklist.md (1 hunks)
  • src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: Focus on inconsistencies, contradictions, edge cases and serious issues.
Avoid commenting on minor issues such as linting, formatting and style issues.
When providing code suggestions, use GitHub's suggestion format:

<code changes>

Files:

  • src/modules/bmm/tasks/daily-standup.xml
  • src/modules/bmm/workflows/4-implementation/dev-story/checklist.md
  • src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml
🔇 Additional comments (5)
src/modules/bmm/workflows/4-implementation/dev-story/checklist.md (1)

58-62: Status token alignment looks correct (“review”). This matches the documented lifecycle and keeps story/sprint status terminology consistent within the checklist.

src/modules/bmm/tasks/daily-standup.xml (1)

10-16: Good normalization in status examples (“in-progress”, “review”). Avoids teaching agents the legacy title-case phrases.

src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml (3)

320-326: Correctly sets canonical Status value to “review”.


342-360: Outputs now accurately reflect the actual written status (“review”). This should help prevent agents from “doing the right thing” but reporting the wrong label.


370-377: Completion messaging matches the canonical status token.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR normalizes story status references throughout the BMM (Business-Model-Management) workflow files from human-readable title case format (e.g., "Ready for Review") to the canonical lowercase kebab-case format (e.g., "review"), ensuring consistency with the documented story lifecycle: backlog → ready-for-dev → in-progress → review → done.

Key Changes:

  • Updated status field value from "Ready for Review" to "review" in workflow instructions and checklist
  • Normalized output messages to reference the actual status value "review" instead of descriptive text
  • Updated example status references in daily standup task

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml Updates story status field to "review" and normalizes all output messages to reference the canonical status value instead of "Ready for Review"
src/modules/bmm/workflows/4-implementation/dev-story/checklist.md Updates final status verification checklist item to use "review" instead of "Ready for Review"
src/modules/bmm/tasks/daily-standup.xml Updates status examples from title case to lowercase kebab-case format (in-progress, review)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@cecil-the-coder cecil-the-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev-story workflow uses 'Ready for Review' but canonical status is 'review'

4 participants