Call BlynkOnDisconnected() on unsuccessful write #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When client is unable to succeed writing to socket (due to broken internet connection, for example), connection to Blynk server is resetting. But, for some reason, the call to BlynkOnDisconnected() was commented out, so sketch is unable to know about such disconnect. Tested on ESP8266 platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call BlynkOnDisconnected() on unsuccessful write
When client is unable to succeed writing to socket (due to broken internet
connection, for example), connection to Blynk server is resetting. But, for
some reason, the call to BlynkOnDisconnected() was commented out, so sketch
is unable to know about such disconnect.
Tested on ESP8266 platform.