Updates for main with no exports #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR changes the intent though. The idea was that if you have I think we should fix it and keep it that way for now. The message needs an update too. I can fix this myself too. With that said, I think the idea of this PR is good, but it'd need to be a new rule, and maybe apply to |
|
Aight that's fixed at 57fdc43. Sorry for the new conflicts and thanks for spotting the bug 😬 |
|
I'll close this one for now and write a new issue so we keep track of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current message is quite confusing to me because
exportsdoesn't have anything to do with ESM. You can use it with CJS as well. This updates it to apply whether the code is CJS or ESM.