Skip to content

Comments

bump Poetry in action and remove requirements.txt#115

Merged
bluet merged 1 commit intobluet:masterfrom
hms5232:master
Dec 31, 2022
Merged

bump Poetry in action and remove requirements.txt#115
bluet merged 1 commit intobluet:masterfrom
hms5232:master

Conversation

@hms5232
Copy link

@hms5232 hms5232 commented Dec 31, 2022

TL;DR

  1. Bump Poetry version (1.1.14 -> 1.2.2 & 1.3.1) in action pipeline
  2. Remove requirements.txt

In #105 , I think it is time to update Poetry. Both of 1.2 and 1.3 add many breaking but useful features (ex: lock file format 2.0). However, some device may face issue when they upgrade from 1.1. For example, my personal computer and raspberry pi 4 work fine, but device my job use failed in upgrade.

Because of those, I set two Poetry version matrix to cover 1.2 and 1.3, but drop 1.1. This mean all maintainer of this project should not use Poetry before version 1.2.

Also, I remove the requirements.txt, maintain pyproject.toml and poetry.lock is the only thing need to do of dependencies management.

If everyone ready, let's merge and move one step closer to the goal (release new packae)!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hms5232 hms5232 mentioned this pull request Dec 31, 2022
@bluet
Copy link
Owner

bluet commented Dec 31, 2022

@hms5232 cool thanks 👍

@bluet bluet merged commit 15afd9a into bluet:master Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants