Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”‘->πŸ—‘οΈ Enable Tiled Admins to delete API Keys belonging to other user's principals #786

Merged
merged 10 commits into from
Oct 3, 2024

Conversation

Kezzsim
Copy link
Contributor

@Kezzsim Kezzsim commented Sep 18, 2024

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

Resolves #766 enhancement request by providing a way for admins to delete keys belonging to other users via principal, through the api/v1/auth/principal/{principal_uuid}/apikey?first_eight={first_eight}' endpoint.

Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some naming suggestions, for consistency with existing methods, and some thoughts on expanding the test.

tiled/client/context.py Outdated Show resolved Hide resolved
tiled/server/authentication.py Outdated Show resolved Hide resolved
tiled/_tests/test_authentication.py Outdated Show resolved Hide resolved
@danielballan danielballan merged commit 5c30719 into bluesky:main Oct 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add route for Tiled admins to revoke API key
2 participants