Rename path argument to "dataset" in hdf5_lookup

[jwlodek]

Checklist

• Add a Changelog entry
• Add the ticket number which this PR closes to the comment section

Recent ophyd_async change renamed the internal HDF path parameter passed to the stream resource to dataset from path.

Required to merge this in sync with bluesky/bluesky#1790.

See: https://github.com/bluesky/ophyd-async/blob/5ac94e283b170b603df42a7d5fe33fd7f2786524/src/ophyd_async/core/_hdf_dataset.py#L64

[genematx]

Looks good to me, thanks Jakub! I'd still wait for a comment from @danielballan before merging it in case path needs to be changed in any other places that I'm not aware of.

[danielballan]

I agree the old name was confusing. This needs a SQL migration to update existing DataSource documents.

[danielballan]

To create a migration script:

$ python -m tiled.catalog revision -m "Change 'path' to 'dataset' in HDF5 assets"
$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

       tiled/catalog/migrations/versions/9cfb45fa2c30_change_path_to_dataset_in_hdf5_assets.py

add to the top of this list:

tiled/tiled/catalog/core.py

Lines 7 to 17 in 15abbc9

	ALL_REVISIONS = [
	"ed3a4223a600",
	"e756b9381c14",
	"2ca16566d692",
	"1cd99c02d0c7",
	"a66028395cab",
	"3db11ff95b6c",
	"0b033e7fbe30",
	"83889e049ddc",
	"6825c778aa3c",
	]

In the migration file created above, you need to run an UPDATE command. Example from another migration:

tiled/tiled/catalog/migrations/versions/e756b9381c14_add_structure_family_to_data_sources.py

Lines 49 to 53 in 15abbc9

	connection.execute(
	data_sources.update()
	.values(structure_family=structure_family)
	.where(data_sources.c.id == data_source_id)
	)