Give blosc2 distinct content-encoding #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padraic-shafer
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Overall this looks right. I noted a couple things as comments.
Also, is it worth updating this how-to in the current PR?
https://github.com/bluesky/tiled/blob/main/docs/source/how-to/client-logger.md
danielballan
force-pushed
the
blosc2-name
branch
from
2fad5ff
to
94260fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #719, making an important correction.
Blosc2 can read blosc1-encoded data, but blosc1 cannot read blosc2-encoded data. Therefore, new Tiled servers will send old tiled clients bytes encoded as
content-encoding: bloscbut the clients were not be able to decode the bytes. @pbeaucage hit this in the wild after we deployed Tiled v0.1.0a119 to tiled.nsls2.bnl.gov yesterday.This PR renamed the
content-encodingheader fromblosctoblosc2. I considered this in #719 but could not quite tell which was correct. In retrospect it seems unambiguous that this is a distinct encoding and needs a distinct header value.