-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'node' to 'container' and shorten URLs. #478
Conversation
This also seemed like the right time to rename the queries on specs and structure families to |
Is there an existing or likely usage where you could meaningfully replace If not, then you can comfortably replace |
Good point. There are things one can do on a Container that one cannot do on just any generic Node. We should rename so that the typing makes sense. 👍 |
I suppose a nice way to transition the node module and its classes would be to create aliases ( |
Done! To make this change fully backward-compatible would get messy very quickly. At this early stage, I think it's better to avoid loading up the codebase with that mess. I am opting to make only a basic effort here---raising clear error message / warnings at least. There is a corresponding update in Databroker, ready to go once Tiled is released. |
* Rename structure family 'node' to 'container', shorten URLs. * Update tree util. * Make test of inlined HFD5 content more thorough. * Update URLs. * Satisfy linters. * Update renamed queries in docs. * Rename client node module and Node class.
Closes #472.
To be determined: Should we update the client module and class
tiled.client.node.Node
totiled.client.container.Container
? I lean "yes" but I do not feel 100% sure. It is technically still a Node, but it is specifically a Container node, so it should be updated, right?