Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs configuration and add 'reject_undeclared_specs'. #383

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

danielballan
Copy link
Member

  • Fixes bug in the code that merges one or more configuration files that entirely dropped the section that declares specs
  • Make reject_undeclared_specs configurable, and off by default, for easy experimentation without getting the server admin to add specs (for @cjtitus)

@danielballan
Copy link
Member Author

I ran this by @dylanmcreynolds for conceptual approval. I will self-merge shortly because @cjtitus has been patiently waiting for this fix for awhile!

@danielballan danielballan merged commit b7f4f77 into bluesky:main Jan 31, 2023
@danielballan danielballan deleted the fix-specs-validation branch January 31, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant