Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to single-process (uvicorn) container #382

Merged
merged 10 commits into from
Jan 31, 2023

Conversation

danielballan
Copy link
Member

Closes #282

  • Remove gunicorn from the containerized deployment
  • Turns Prometheus metrics on by default
  • Makes the multiprocess mechanism in Prometheus (the memory-mapped files) optional, off by default
  • Simplifies Dockerfile
  • Moves the code that checks for scalable config settings out of a one-off script and into the CLI as --scalable

@dylanmcreynolds
Copy link
Contributor

I think this is a great simplification. Gunicorn was seen as a necessary step to acheive scaling, but the realization that even docker-compose can easily perform round-robin load balancing lets us take a lot of complexity out of containers and into the deployment, where it belongs.

It is truly sad that podman-compose doe not achieve this out of the box. In that case, one could imagine a gunicorn container and multiple tiled containers to achieve horizontal scaling.

@danielballan danielballan merged commit f2369ce into bluesky:main Jan 31, 2023
@danielballan danielballan deleted the no-gunicorn branch January 31, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit Dockerfile
2 participants