Add status repr to WaitTimeoutError message#1088
Merged
tacaswell merged 1 commit intobluesky:masterfrom Jan 23, 2023
Merged
Conversation
tacaswell
approved these changes
Jan 23, 2023
Contributor
|
Thank you @dperl-dls ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a similar situation to #1086 , we had an issue where the error message
Status has failed to completewas not very illuminating as to which status that was, so I have added this information to theraise WaitTimeoutErrorcalls in the same manner as it is added to other exception messages instatus.py. This would be really helpful to us in avoiding wrapping everywait()with try/except to record what we are waiting on or subclassing every kind of status we have to modifywait()and I hope it might be useful to others too.