Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserve time and seq_num keys #223

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gwbischof
Copy link
Contributor

@gwbischof gwbischof commented May 24, 2022

user-defined data_keys called "time" or "seq_num" conflict with with bluesky generated keys of the same name. This PR reserves this keys, preventing users from using them.

@gwbischof
Copy link
Contributor Author

@tacaswell
Copy link
Contributor

Do we have any users currently using them?

@dmgav
Copy link
Contributor

dmgav commented May 25, 2022

@danielballan
Copy link
Member

The intent is to pair this with a migration tool (similar to "shape fixer") to alter the names on existing data.

@danielballan
Copy link
Member

This needs:

  • a substantial rebase, as the system for encoding schemas has evolved substantially
  • a clear story for how to deal with existing usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants