-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sentence to ensure app password name letters are English #973
base: main
Are you sure you want to change the base?
Conversation
Is this the case? I just glanced through the server code and didnt see this constraint |
You mean this client-side constraint right? social-app/src/view/com/modals/AddAppPasswords.tsx Lines 103 to 107 in edb37e2
|
Oh interesting, right. @ansh do you remember why we have those rules? |
Yeah, I put that in there just so to prevent users from shooting themselves in the foot since we had no server-side validation as you noted. @pfrazee |
Huh -- is there a reason we have that constraint though? |
@pfrazee No reason other than people not putting weird app password names and breaking things. We can revert it. |
@ansh yeah if we have any specific ways we know it'll break things, we should keep it. I just can't think of any |
@pfrazee Nothing specific. I was just being overly cautious. Should we remove it, then? |
Yeah I think so? |
No description provided.