Plc auth lib integration #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM! |
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* parsing dids to something we understand * revamping did-sdk with did-resolver * testing * fixing some thigns & finishing tests * fix type error & remove old test * wip * create did on server & add email * check username available & store email * better test utils * remove did:test * allow authstore to sign for controlled dids * plc ucan integration wip * wip * finished auth lib refactor * integrating to repo & server * couple fix ups * couple more fixups * disable dev-env test * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this out into it's own PR cause it was sort of its own branch of work.
This works did:plc resolution into our auth lib.
tbh I'm not particularly thrilled with how this turned out, but I'm not sure of our other option.
The main change in DX is that we can't just call verification code from the auth lib, we have to instantiate a
Verifierthat encapsulates some DID resolution & verification logic. This is because resolving dids takes parameters (timeout&plcUrl) which means those have to pass through to any function that may require DID resolution.I briefly thought about ripping out the UCAN stuff, but we'd end up building something with a similar shape anyway, so I ended up leaving it in for now to avoid having to refactor repo code.