Settings manager: Create a class to manage all shared settings #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
force-pushed
the
settings_manager
branch
from
cedae6f
to
71cf4bc
Compare
jaxxzer
reviewed
Jul 4, 2018
src/logger.cpp
Outdated
| @@ -42,7 +34,7 @@ void Logger::installHandler() | |||
| originalHandler = qInstallMessageHandler(handleMessage); // This function returns the previous message handler | |||
|
|
|||
| if (qEnvironmentVariableIsEmpty("QT_MESSAGE_PATTERN")) { | |||
| qSetMessagePattern(QStringLiteral("%{time [hh:mm:ss.zzz]} %{message}")); | |||
There was a problem hiding this comment.
Was adding this hunk intentional? What does this do?
There was a problem hiding this comment.
Ops, my bad, I was using a personal pattern while debugging.
jaxxzer
reviewed
Jul 4, 2018
| @@ -115,7 +114,6 @@ class Logger : public QObject | |||
| QFile _file; | |||
| QTextStream _fileStream; | |||
| QStringList _registeredCategories; | |||
| QSettings _settings; | |||
There was a problem hiding this comment.
Can we assign SettingsManager::self()->settings() to a member _settings, and use that everywhere for better readability?
There was a problem hiding this comment.
Yep, Will do that
patrickelectric
force-pushed
the
settings_manager
branch
from
71cf4bc
to
1206aa3
Compare
jaxxzer
approved these changes
Jul 5, 2018
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
settings_manager
branch
3 times, most recently
from
ebb708c
to
b3487f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #205
Will help #199
Fix #42