Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to Pandas breaking change, bump Python version #101

Merged
merged 6 commits into from
Aug 12, 2020

Conversation

vinceatbluelabs
Copy link
Contributor

@vinceatbluelabs vinceatbluelabs commented Aug 11, 2020

Pandas 1.1 has broken Record Mover's usage of the read_csv() function by adding error checking in cases where a certain argument would be unused.

Details of the Pandas change:

See Records Mover test failures here:

@@ -1 +1 @@
records-mover-3.8.3
records-mover-3.8.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump to latest Python.

@vinceatbluelabs vinceatbluelabs marked this pull request as ready for review August 11, 2020 20:29
@vinceatbluelabs vinceatbluelabs changed the title Adjust to pandas breaking change, bump Python version Adjust to Pandas breaking change, bump Python version Aug 11, 2020
Copy link
Contributor

@cwegrzyn cwegrzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests broke, now they pass, seems good! And as always appreciate the documentary evidence :)

@vinceatbluelabs vinceatbluelabs merged commit d368dc6 into master Aug 12, 2020
@vinceatbluelabs vinceatbluelabs deleted the adjust_to_pandas_breaking_change branch August 12, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants