draft; add bytea support #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
reviewed
Feb 1, 2020
| impl From<&[u8]> for PgDatum<'_> { | ||
| fn from(value: &[u8]) -> Self { | ||
| let ptr = unsafe{ | ||
| // :consider should palloc be guard_pg'd? |
There was a problem hiding this comment.
yes, all calls (or blocks of calls) into PG functions should be guarded.
| l &= 0x3fffffff; | ||
| l <<= 2; | ||
|
|
||
| unsafe { |
There was a problem hiding this comment.
This all feels like it could be captured into a generic allocate and align function, maybe?
| } | ||
| } | ||
|
|
||
| impl<'s> TryFromPgDatum<'s> for &[u8] { |
There was a problem hiding this comment.
I think we want &'s [u8] here, right? and then we should make sure that 's is bound by 'mc, right? in other words, this byte array should be bounded by the lifetime of the memory context that encapsulates it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
bytea.This PR is rough. I mostly ripped off the implementation for
Textwhere possible.There's a lot of
unsafein here that I'm not sure I'm respecting the invariants of. I also don't understand the current state of allocation in the codebase (should IpallocorMemoryContextAlloc?).If anyone has time to explain to me the Right Way to do things, I am happy to do a rewrite. Otherwise, hopefully someone can use this as stub code.