This repository was archived by the owner on May 25, 2023. It is now read-only.
Allow configuration of iframe src attribute #2652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you have an alternate thought on how to solve this problem, but the change is simple enough that kicking it off with a pull request makes sense to me.
Inspiration:
In my org, we're planning to ship with Content Security Policy enabled.
This poses a minor problem with the iframe transport, which uses
src="javascript:false;"
, leading to the following error (in Firefox, Chrome gives a similar error):Content Security Policy: Directive inline script base restriction violated
Proposed Solution:
Allow the user of the iframe transport to configure the iframe's src attribute. Default to the old behavior,
javascript:false;
.In my org, all the browsers we plan on supporting handle
about:blank
, so we could go with that, fixing the issue and preventing any error from getting logged.