This repository was archived by the owner on May 25, 2023. It is now read-only.
Fix to prevent extra progress callback #2082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields up to date, not the original options Otherwise the test at the beginning of _onDone fails and an extra overall progress event is sent with a loaded number that is total * 2.
|
I was seeing this error as well (200% progress). This fix seems to work. |
Owner
|
Thanks for your contribution. |
Author
|
No need to apologize, you know the code a little better than me! |
Owner
|
Thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently chunked uploading is not passing the updated options to
_onDone, which causes the test at the beginning to fail (becauseoptions.loadedandoptions.totalare missing), which then causes an extra progress event to be sent withloaded==total * 2.By passing the updated options to
_onDone, everything works as expected.