Skip to content

Commit

Permalink
refactor!: remove unused playerStateStream (#1280)
Browse files Browse the repository at this point in the history
Remove unused player state stream. See this comment.

BREAKING CHANGE: But it should not play a role:

stream was never called, so it never emitted any events, (except for web, which also already emits onComplete event). So most likely no-one did listen to this stream.
the according stream is further exposed in main audioplayers package, so it's not breaking the main package.
  • Loading branch information
Gustl22 authored Sep 26, 2022
1 parent 4aaee70 commit 27f9de2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'dart:typed_data';
import 'package:audioplayers_platform_interface/api/audio_context_config.dart';
import 'package:audioplayers_platform_interface/api/for_player.dart';
import 'package:audioplayers_platform_interface/api/player_mode.dart';
import 'package:audioplayers_platform_interface/api/player_state.dart';
import 'package:audioplayers_platform_interface/api/release_mode.dart';
import 'package:audioplayers_platform_interface/method_channel_audioplayers_platform.dart';
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
Expand Down Expand Up @@ -120,8 +119,6 @@ abstract class AudioplayersPlatform extends PlatformInterface {
/// * otherwise not supported (e.g. LOW_LATENCY mode on Android)
Future<int?> getCurrentPosition(String playerId);

Stream<ForPlayer<PlayerState>> get playerStateStream;

Stream<ForPlayer<Duration>> get positionStream;

Stream<ForPlayer<Duration>> get durationStream;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:async';

import 'package:audioplayers_platform_interface/api/for_player.dart';
import 'package:audioplayers_platform_interface/api/player_state.dart';
import 'package:flutter/foundation.dart';

mixin StreamsInterface {
Expand All @@ -13,10 +12,6 @@ mixin StreamsInterface {
_completeStreamController.add(ForPlayer(playerId, null));
}

void emitPlayerState(String playerId, PlayerState value) {
_playerStateStreamController.add(ForPlayer(playerId, value));
}

void emitDuration(String playerId, Duration value) {
_durationStreamController.add(ForPlayer(playerId, value));
}
Expand All @@ -34,9 +29,6 @@ mixin StreamsInterface {
Stream<ForPlayer<Duration>> get durationStream =>
_durationStreamController.stream;

Stream<ForPlayer<PlayerState>> get playerStateStream =>
_playerStateStreamController.stream;

Stream<ForPlayer<Duration>> get positionStream =>
_positionStreamController.stream;

Expand All @@ -49,9 +41,6 @@ mixin StreamsInterface {
final StreamController<ForPlayer<Duration>> _durationStreamController =
StreamController<ForPlayer<Duration>>.broadcast();

final StreamController<ForPlayer<PlayerState>> _playerStateStreamController =
StreamController<ForPlayer<PlayerState>>.broadcast();

final StreamController<ForPlayer<Duration>> _positionStreamController =
StreamController<ForPlayer<Duration>>.broadcast();

Expand All @@ -60,7 +49,6 @@ mixin StreamsInterface {
_seekCompleteStreamController.close();
_completeStreamController.close();
_durationStreamController.close();
_playerStateStreamController.close();
_positionStreamController.close();
}
}
2 changes: 0 additions & 2 deletions packages/audioplayers_web/lib/wrapped_player.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:async';
import 'dart:html';

import 'package:audioplayers_platform_interface/api/player_state.dart';
import 'package:audioplayers_platform_interface/api/release_mode.dart';
import 'package:audioplayers_platform_interface/streams_interface.dart';

Expand Down Expand Up @@ -80,7 +79,6 @@ class WrappedPlayer {
playerEndedSubscription = p.onEnded.listen((_) {
pausedAt = 0;
player?.currentTime = 0;
streamsInterface.emitPlayerState(playerId, PlayerState.stopped);
streamsInterface.emitComplete(playerId);
});
}
Expand Down

0 comments on commit 27f9de2

Please sign in to comment.