Enforce fatal error if an include fails #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires pull request on treasure-map to be merged bluebrown/treasure-map#1
Closed
|
Hi thanks for the PR. This doesnt seem to be ready to be merged mas its chainging alot of things that are specific to your fork. |
|
Sorry for the confusion. I am surprised to see that the 5 commits I added 2 hours ago were added to the PR, just because I am working from the main branch. You would want to just cherry pick this trivial change, and not the rest of my opinionated commits, which are not meant to be merged: It effectively passes true to |
Preserves build edge specification when using -o
makes it possible to use this with ninja build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires pull request on treasure-map to be merged bluebrown/treasure-map#1
This could be made into a cli option, but I would highly recommend fatal error by default.