Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRASH] Uninstalling a PWA causes Chromium to crash #212

Open
Wowfunhappy opened this issue Mar 10, 2024 · 1 comment
Open

[CRASH] Uninstalling a PWA causes Chromium to crash #212

Wowfunhappy opened this issue Mar 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 10, 2024 •
edited
Loading

Describe the bug

Uninstalling a PWA causes Chromium to crash. Chromium will continue to crash on every subsequent launch until you delete the associated .app shortcut.

Steps to reproduce the behavior:

  1. Go to a website such as maps.google.com that supports PWAs.
  2. Click on the "Install" button toward the right side of the address bar. Follow the prompts to install the app.
  3. Once the app is installed, go to chrome://apps. Right click the app and select "Uninstall"
  4. Chromium will crash.
  5. Chromium will continue to crash every time you open the app, until you delete Google Maps.app.

Workarounds

Delete PWAs by dragging the .app to the trash before/after they are uninstalled from chrome://apps.

System

  • OS: OS X 10.9.5 (13F1911)
  • Chromium Legacy 121.0.6167.160.1

Logs

I am attaching four different crash logs from four different instances of trying to open Chromium post app removal, as they are quite different.

Archive.zip
@Wowfunhappy Wowfunhappy added the bug Something isn't working label Mar 10, 2024
@Wowfunhappy Wowfunhappy changed the title [CRASH] [CRASH] Uninstalling a PWA causes Chromium to crash on every subsequent launch Mar 10, 2024
@Wowfunhappy
Copy link
Author

Wowfunhappy commented Mar 18, 2024 •
edited
Loading

It turns out there's a very easy workaround: just delete the PWA's .app file before/after you uninstall the PWA from chrome://apps. I'm not sure how I missed this the first time!

@Wowfunhappy Wowfunhappy changed the title [CRASH] Uninstalling a PWA causes Chromium to crash on every subsequent launch [CRASH] Uninstalling a PWA causes Chromium to crash Mar 29, 2024
blueboxd pushed a commit that referenced this issue May 16, 2024
[M124][LogoPolish] Implement logo polish.
6f2cf71 
This CL modifies the height, top margin, and bottom margin of the logo
when Logo Polish is activated. The height of the logo is decided by the
selected variation.

The screenshots are included in the following link:
https://docs.google.com/document/d/16z7y1lXiSJ0sCZ0-UzrXdBC8H2idDrVdVarJ4DIEuho/edit?usp=sharing

(cherry picked from commit 89460ed)

Bug: 328769923
Change-Id: I4d77d36271ea7e5a8b0f620fafae09d614d238de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5356197
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1275663}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391681
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#212}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wowfunhappy