Skip to content

Commit

Permalink
no_symbols for linux-lacros-rel
Browse files Browse the repository at this point in the history 
This will make compile step faster.
Previously symbol_level=0 means no symbol. But llvm changed the
behavior. Now it contains function names, which in general is
fine for developers.

This is the result for linux-lacros-rel:
symbol_level=0: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/247920?
The browser_tests shard 0 contains:
../../chrome/browser/profiles/profile_manager_browsertest.cc:616: Failure
Expected equality of these values:
  2U
    Which is: 2
  chrome::GetTotalBrowserCount()
    Which is: 1
Stack trace:
#0 0x56441415eea1 ProfileManagerBrowserTest_PRE_AddMultipleProfiles_Test::RunTestOnMainThread()
#1 0x56441a1d278c content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#2 0x564413970763 chrome_service_worker_browser_test::ChromeServiceWorkerLinkFetchTest::ManifestCallbackAndRun()
#3 0x5644199f3cce ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#4 0x5644199f3024 ChromeBrowserMainParts::PreMainMessageLoopRun()
#5 0x564416e69bef content::BrowserMainLoop::PreMainMessageLoopRun()
#6 0x56441740a676 content::StartupTaskRunner::RunAllTasksNow()
#7 0x564416e69855 content::BrowserMainLoop::CreateStartupTasks()
#8 0x564416e6c10b content::BrowserMainRunnerImpl::Initialize()
#9 0x564416e67dd7 content::BrowserMain()
#10 0x564417d95478 content::ContentMainRunnerImpl::RunBrowser()
#11 0x564417d94ec0 content::ContentMainRunnerImpl::Run()
#12 0x564417d92d1c content::RunContentProcess()
#13 0x564417d92ded content::ContentMain()
#14 0x56441a1d1a78 content::BrowserTestBase::SetUp()
#15 0x5644197edc5e InProcessBrowserTest::SetUp()

symbol_level=1: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/248772
The browser_tests shard 0 contains:
../../chrome/browser/profiles/profile_manager_browsertest.cc:616: Failure
Expected equality of these values:
  2U
    Which is: 2
  chrome::GetTotalBrowserCount()
    Which is: 1
Stack trace:
#0 0x5565d9f0f621 ProfileManagerBrowserTest_PRE_AddMultipleProfiles_Test::RunTestOnMainThread()
#1 0x5565dff88ebc content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#2 0x5565d971fe93 chrome_service_worker_browser_test::ChromeServiceWorkerLinkFetchTest::ManifestCallbackAndRun()
#3 0x5565df7aa9ce ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#4 0x5565df7a9d24 ChromeBrowserMainParts::PreMainMessageLoopRun()
#5 0x5565dcc1fbdf content::BrowserMainLoop::PreMainMessageLoopRun()
#6 0x5565dd1c09c6 content::StartupTaskRunner::RunAllTasksNow()
#7 0x5565dcc1f845 content::BrowserMainLoop::CreateStartupTasks()
#8 0x5565dcc220fb content::BrowserMainRunnerImpl::Initialize()
#9 0x5565dcc1ddc7 content::BrowserMain()
#10 0x5565ddb4ce78 content::ContentMainRunnerImpl::RunBrowser()
#11 0x5565ddb4c8c0 content::ContentMainRunnerImpl::Run()
#12 0x5565ddb4a71c content::RunContentProcess()
#13 0x5565ddb4a7ed content::ContentMain()
#14 0x5565dff881a8 content::BrowserTestBase::SetUp()
#15 0x5565df5a494e InProcessBrowserTest::SetUp()
It's the same debug information.

Bug: 1221324
Change-Id: I96a0768508cf9bd073a5522e792a4120606bddb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965870
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893997}
  • Loading branch information
Sven Zheng authored and Chromium LUCI CQ committed Jun 18, 2021
1 parent 03f3b61 commit d97fca2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/mb/mb_config.pyl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2287,7 +2287,7 @@
],

'lacros_on_linux_release_trybot': [
'lacros_on_linux', 'release_trybot', 'also_build_ash_chrome',
'lacros_on_linux', 'release_trybot', 'also_build_ash_chrome', 'no_symbols',
],

'libfuzzer_asan_debug_bot': [
Expand Down
2 changes: 1 addition & 1 deletion tools/mb/mb_config_expectations/tryserver.chromium.chromiumos.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@
"is_debug": false,
"ozone_platform": "wayland",
"ozone_platform_wayland": true,
"symbol_level": 1,
"symbol_level": 0,
"target_os": "chromeos",
"use_goma": true,
"use_gtk": false,
Expand Down
2 changes: 1 addition & 1 deletion tools/mb/mb_config_expectations/tryserver.chromium.linux.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@
"is_debug": false,
"ozone_platform": "wayland",
"ozone_platform_wayland": true,
"symbol_level": 1,
"symbol_level": 0,
"target_os": "chromeos",
"use_goma": true,
"use_gtk": false,
Expand Down

0 comments on commit d97fca2

Please sign in to comment.