forked from chromium/chromium
-
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix <output>.defaultValue for descendant mutations
The ChildrenChanged listener which updates defaultValue doesn't account for mutations deeper than the first layer of children. This patch accounts for it by computing textContent more often instead of relying on ChildrenChanged. This was brought up in this whatwg/html discussion [1]. Based on domenic's suggestion [2], I heavily based this on the jsdom implementation [3]. [1] whatwg/html#6516 [2] whatwg/html#6516 (comment) [3] https://github.com/jsdom/jsdom/blob/04f6c13f4a4d387c7fc979b8f62c6f68d8a0c639/lib/jsdom/living/nodes/HTMLOutputElement-impl.js Change-Id: I2f491f3c2759f1d3ca4fce1025f5677e34479d6f Fixed: 1206416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878397 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#881932}
- Loading branch information
1 parent
e2542fe
commit 922348f
Showing
3 changed files
with
12 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 0 additions & 5 deletions
5
..._tests/external/wpt/html/semantics/forms/the-output-element/mutations.window-expected.txt
This file was deleted.
Oops, something went wrong.