Skip to content

Commit

Permalink
[CrOS Cellular] Modifying the hermes network operation timeout
Browse files Browse the repository at this point in the history
Our operation timeout was set to 4 min and that is in line with
platform's timeout for carrier call. However, theoretically, the call
could take little over 4 mins end to end if the carrier call itself
takes up 4 mins. We have received some reports of DBUS_NOREPLY that
would confirm this.

Bug: b/244447732
Change-Id: Ia8a14f10a2935840fb5c3593e6e0bd785b8bb10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4763105
Reviewed-by: Jason Zhang <jiajunz@google.com>
Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com>
Cr-Commit-Position: refs/heads/main@{#1181205}
  • Loading branch information
Nikhil Nayunigari authored and Chromium LUCI CQ committed Aug 8, 2023
1 parent 9969033 commit 2b50cb4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions chromeos/ash/components/dbus/hermes/constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

namespace ash::hermes_constants {

// 4min * 60s/min * 1000ms/s.
int kHermesNetworkOperationTimeoutMs = 4 * 60 * 1000;
// 6min * 60s/min * 1000ms/s.
int kHermesNetworkOperationTimeoutMs = 6 * 60 * 1000;

// 2min * 60s/min * 1000ms/s
int kHermesOperationTimeoutMs = 2 * 60 * 1000;
Expand Down

0 comments on commit 2b50cb4

Please sign in to comment.