Skip to content

Commit

Permalink
Prerender: Re-enable PrerenderPageLoadMetricsObserverBrowserTest::
Browse files Browse the repository at this point in the history
Activate_SpeculationRule

This test was disabled two years ago and we cannot access the test log
anymore.
To figure out if the issue has been fixed or not, this CL tentatively
re-enables the test.

To Gardener: feel free to revert this change and I'd appreciate it if
you could share some failure log!

Bug: 40842862
Change-Id: Ic30b305f804ab4a54eacd3a19a726af2103f6ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5574607
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306686}
  • Loading branch information
Clqsin45 authored and pull[bot] committed May 28, 2024
1 parent 53c7cc2 commit 1317131
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,8 @@ class PrerenderPageLoadMetricsObserverBrowserTest
base::test::ScopedFeatureList scoped_feature_list_;
};

// TODO(crbug.com/40842862): Re-enable this test
#if BUILDFLAG(IS_MAC)
#define MAYBE_Activate_SpeculationRule DISABLED_Activate_SpeculationRule
#else
#define MAYBE_Activate_SpeculationRule Activate_SpeculationRule
#endif
IN_PROC_BROWSER_TEST_F(PrerenderPageLoadMetricsObserverBrowserTest,
MAYBE_Activate_SpeculationRule) {
Activate_SpeculationRule) {
ASSERT_TRUE(embedded_test_server()->Start());

// Navigate to an initial page.
Expand Down

0 comments on commit 1317131

Please sign in to comment.