fix(inspector): clamp negative EIP-3155 refund to zero - #3872
Open
cuiweixie wants to merge 1 commit into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Casting a negative i64 refund to u64 wraps to a huge value in the tracer output; clamp like state_gas so the JSON field stays a valid unsigned counter.
cuiweixie
force-pushed
the
fix/eip3155-clamp-negative-refund
branch
from
August 27, 2026 23:42
2ce4828 to
c3cb859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refundedwith.max(0)before casting tou64in the EIP-3155 tracer.i64refund previously wrapped to a huge unsigned value in the JSON output; this matches the existingstate_gasclamp.Test plan
cargo nextest run -p revm-inspectorcargo clippy --workspace --all-targets --all-features