Fix CLI exit code for invalid bytecode input #2968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: The
revme bytecode
command was returning exit code 0 (success) even when provided with invalid hex input or unsupported EOF bytecode, making it impossible for scripts/CI to detect input validation failures.Solution:
bytecode::Cmd::run()
to returnResult<(), Error>
instead of()
MainCmd::run()
to ensure non-zero exit codesImpact:
revme bytecode <invalid_hex>
now correctly returns exit code 1