Skip to content

Conversation

viktorking7
Copy link
Contributor

Description

Problem: The revme bytecode command was returning exit code 0 (success) even when provided with invalid hex input or unsupported EOF bytecode, making it impossible for scripts/CI to detect input validation failures.

Solution:

  • Modified bytecode::Cmd::run() to return Result<(), Error> instead of ()
  • Return proper errors for invalid hex strings and EOF bytecode instead of silent success
  • Propagate errors through MainCmd::run() to ensure non-zero exit codes

Impact:

  • revme bytecode <invalid_hex> now correctly returns exit code 1
  • Improves CLI reliability for automation and CI pipelines
  • Maintains backward compatibility for valid inputs

Copy link

codspeed-hq bot commented Sep 12, 2025

CodSpeed Performance Report

Merging #2968 will not alter performance

Comparing viktorking7:main (232d775) with main (60f06c0)

Summary

✅ 173 untouched

@rakita rakita merged commit cb2ed53 into bluealloy:main Sep 12, 2025
31 checks passed
@github-actions github-actions bot mentioned this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants