Skip to content

Conversation

Forostovec
Copy link
Contributor

The validate_tx_env function declared a second generic parameter (Error) that was never used and the function always returned Result<(), InvalidTransaction>. This created the false impression that the error type was configurable, while the implementation was fixed. The unused generic caused confusion and added no value. This commit removes the extraneous generic and updates the sole call in validate_env to use only ::, aligning with the module’s error-handling design where inner validators return InvalidTransaction and the outer layer maps to the handler’s error type.

Copy link

codspeed-hq bot commented Sep 8, 2025

CodSpeed Performance Report

Merging #2946 will not alter performance

Comparing Forostovec:feat/cleanup-validation-tx-env-generic (7b5c834) with main (1476cf6)

Summary

✅ 173 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 2d79c28 into bluealloy:main Sep 8, 2025
31 checks passed
This was referenced Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants