Skip to content

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 2, 2025

In go-ethereum, the name SelfdestructRefundGas is used (https://github.com/ethereum/go-ethereum/blob/f3c696fa1db75d0f78ea47dd0975f6f0de6fdd84/params/protocol_params.go#L90).
A more suitable name might be REFUND_SELFDESTRUCT. Feel free to close this.

Copy link

codspeed-hq bot commented Sep 2, 2025

CodSpeed Performance Report

Merging #2937 will not alter performance

Comparing nkysg:chore_refund_selfdestruct (cabddfc) with main (f9ebc5f)

Summary

✅ 173 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, as it is a gas for refund. I have renamed it to SELFDESTRUCT_REFUND so that 'selfdestruct' is read first.

nkysg and others added 2 commits September 2, 2025 19:14
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
@nkysg nkysg changed the title chore: rename SELFDESTRUCT to REFUND_SELFDESTRUCT chore: rename SELFDESTRUCT to SELFDESTRUCT_REFUND Sep 2, 2025
@rakita rakita merged commit 0ca6564 into bluealloy:main Sep 2, 2025
31 checks passed
@nkysg nkysg deleted the chore_refund_selfdestruct branch September 2, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants