Skip to content

Conversation

Soubhik-10
Copy link
Contributor

@Soubhik-10 Soubhik-10 commented Aug 30, 2025

closes #2932

Copy link

codspeed-hq bot commented Aug 30, 2025

CodSpeed Performance Report

Merging #2934 will not alter performance

Comparing Soubhik-10:amsterdam (c00a4b3) with main (0a6825a)

Summary

✅ 173 untouched benchmarks

CANCUN => Self::CANCUN,
PRAGUE => Self::PRAGUE,
OSAKA => Self::OSAKA,
OSAKA | AMSTERDAM => Self::OSAKA,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a todo here?
but for now this seems okay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine without todo and we can add Amsterdam in PrecompileSpecId when EIPs for precompile gets included

@rakita rakita merged commit f9ebc5f into bluealloy:main Aug 30, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Amsterdam variant in SpecId
3 participants