chore: improve ExtBytecode hash handling #2826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently in foundry we check for None OR hash==zero to check if it's unset. Use `None` in all cases. - Provide a helper for `get_or_insert_with()` that calculates the hash if unset.
DaniPopes
force-pushed
the
ext-bytecode-hash
branch
from
6358597 to
5c58604
Compare
CodSpeed Performance ReportMerging #2826 will not alter performanceComparing Summary
|
Closed
This was referenced Aug 4, 2025
Closed
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonein all cases.get_or_insert_with()that calculates the hash if unset.