Skip to content

chore: fix run-tests.sh #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
+23 −17
Merged

chore: fix run-tests.sh #2801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions crates/handler/src/validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,13 +389,16 @@ mod tests {
];
let bytecode: Bytes = init_code.into();
let result = deploy_contract(bytecode, Some(SpecId::OSAKA));
assert!(matches!(
result,
Ok(ExecutionResult::Halt {
reason: HaltReason::CreateContractSizeLimit,
..
},)
));
assert!(
matches!(
result,
Ok(ExecutionResult::Halt {
reason: HaltReason::CreateContractSizeLimit,
..
},)
),
"{result:?}"
);
}

#[test]
Expand All @@ -411,13 +414,16 @@ mod tests {
];
let bytecode: Bytes = init_code.into();
let result = deploy_contract(bytecode, Some(SpecId::PRAGUE));
assert!(matches!(
result,
Ok(ExecutionResult::Halt {
reason: HaltReason::CreateContractSizeLimit,
..
},)
));
assert!(
matches!(
result,
Ok(ExecutionResult::Halt {
reason: HaltReason::CreateContractSizeLimit,
..
},)
),
"{result:?}"
);
}

#[test]
Expand Down
6 changes: 3 additions & 3 deletions scripts/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ./run-tests --help
#!/usr/bin/env bash
set -eo pipefail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you encounter a problem without pipefail?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -e doesnt work in pipes so this adds some extra robustness

the error was shebang not being in the first line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see


#!/bin/bash
set -e
# Usage: ./scripts/run-tests.sh --help

# Version for the execution spec tests
VERSION="v4.4.0"
Expand Down
Loading